Razvan Pricop

Results 7 comments of Razvan Pricop

Add to_json method to CDP events

I understand that, but my use case is a little different. I have a program that uses python-cdp to listen to CDP events, and I want to add functional tests....

Can't get cdp.dom.get_document() when network.enable()

This probably happens because the CDP API doesn't match the wrapper layer of pycdp. This is generally fixed by updating the wrappers (see `Updating built-in CDP wrappers` section in the...

#11990 Return SOA record and set AA flag when response is NXDOMAIN but QNAME is in the authoritative zone

> t it tends to expand the size of changes a Yeah, I totally get that. At first, the refactoring changes didn't seem so big. But when I ran the...

#11990 Return SOA record and set AA flag when response is NXDOMAIN but QNAME is in the authoritative zone

please review

#11990 Return SOA record and set AA flag when response is NXDOMAIN but QNAME is in the authoritative zone

> Thanks for the updates. I see that the tests pass now. > > Is this PR ready for review? @adiroiban Yes, it's ready.

#11990 Return SOA record and set AA flag when response is NXDOMAIN but QNAME is in the authoritative zone

> When a PR is ready for review, you can ensure that it gets into the queue for maintainers to review by telling our bot, “please review”, like this: Thanks!...

#11990 Return SOA record and set AA flag when response is NXDOMAIN but QNAME is in the authoritative zone

Thanks for the review, @glyph! I believe the backwards compatibility issue is the greatest blocker of this PR. So, I'll prioritise that, first to see if we can solve it....