Raymond Berger
Raymond Berger
PR here: #9182 ### Problem I noticed we have quite a few instances of unused imports in our python code. Perhaps some have side effects but many do not appear...
### Problem Is is on by default for ruff but we have it disabled. Is there a reason why? If not, it is auto-fixable with ruff and we have 12...
Closes #9181 ### Technical ### Testing The tests are passing, and things work fine locally. But we should be thoughtful about if any of these removed imports have side effects...
### Problem This PR can't be worked on until the following is merged: #8930 Currently we have different loader files: - `/static/images/ajax-loader.gif` used nowhere - `static/css/ajax-loader.gif` used in two places....
Closes #9176 This gets ride of inline js from head.html and footer.html. After this, the only place left is in Swagger but we're still figuring out what to do with...
Closes #9118 ### Technical Add typehints to the function to reflect what it actually returns. Update the logic as mentioned [here](https://github.com/internetarchive/openlibrary/issues/9118#issuecomment-2069496193). ### Testing I'm not sure how to test this....
I noticed that [here](https://github.com/internetarchive/openlibrary/blob/master/renovate.json) we have it hardcoded to auto merge updates from `"mypy", "pytest", "pytest-asyncio", "ruff", "safety"`. That's 5/8 of the packages in https://github.com/internetarchive/openlibrary/blob/master/requirements_test.txt Instead, we could make this...
### Problem I ran this code: ```js await fetch("/api/import", { method: "POST", body: JSON.stringify({ identifiers: { isbn_13: ["978-3-943075-58-8"] }, title: "UX Design Process", languages: ["eng"], publishers: ["Smashing Media AG"], publish_date:...
### Problem Best I can tell openlibrary/templates/contact/spam/sent.html is dead code, not used anywhere. If it is then lets delete it. If it's not, we might want to add internationalization to...
part of #4474 (to be done last when `window.q` is no longer necessary) As far as I can tell, window.q isn't used anywhere. If it is, it is very well...