vaults

vaults copied to clipboard

Missing whitepaper and broken doc link

2

No further explanation is needed. The [docs link](https://docs.rari.capital/vaults) in the README resolves to a 404. I'm assuming the correct link is https://docs.rari.capital/yag/. There's still no white paper too.

0xsomnus

ci: add forge

2

As title, uses foundry-action for fast forge installation from latest nightly release

gakonst

seize strategy is rly unsafe imo, consider removing. regardless, this line can cause underflow in totalHoldings. should change to `if (lockedProfit() > totalStrategyHoldings - strategyBalance)` https://github.com/Rari-Capital/vaults/blob/2edd5eb011553af0a9de78d18132fe07c8d841e8/src/Vault.sol#L856

transmissions11

🔒 Critical underflow

1

major underflow here, cannot do in unchecked. https://github.com/Rari-Capital/vaults/blob/2edd5eb011553af0a9de78d18132fe07c8d841e8/src/Vault.sol#L372

transmissions11

transmissions11

transmissions11

🔒 Check use of unchecked {}

1

not sure this is actually sound cuz balances are uint248s

transmissions11

💥 Consider switching strats to 4626 vaults?

1

transmissions11

📝 Whitepaper + technical spec

1

transmissions11

✅ Tests for config functions

1

transmissions11