🔒 Critical underflow

Open transmissions11 opened this issue 3 years ago • 1 comments

major underflow here, cannot do in unchecked.

https://github.com/Rari-Capital/vaults/blob/2edd5eb011553af0a9de78d18132fe07c8d841e8/src/Vault.sol#L372

Mar 04 '22 05:03 transmissions11

maybe could do the subtraction of locked profit from totalStrategyHoldings + totalFloat unchecked

Mar 04 '22 05:03 transmissions11