Benjamin Reed
Benjamin Reed
> Dear @RangerRick > > Could you please provide the feedback for this pull request? I believe ading tests would increase the coverage and the quality for the project. >...
@imdhruva hey, just checking in on this, seems like a useful thing but there was some feedback from @bootc and also files have moved around a bit in preparation for...
@Nabsku We've just done some rearranging of the repo to align it better with common practice for Helm charts. Mind rebasing this to match the new paths? Also, it looks...
I will blame this on reading through too many issues at once. I _swear_ I did a `git grep` and didn't see the references, but I was clearly blind. 😅
@Nabsku FYI, I've pushed a couple of updates to your branch so the tests would get farther, but I am flummoxed by the linting error now. The indentation seems right,...
@iamroddo Hey, I'm going to be helping to take over maintainership of this helm chart and I just wanted to check in on this PR. It looks reasonably simple, but...
Ooh, I realize this is languishing in PRs, but it would be really handy if it could be included.
Wondering this as well. I'd think you'd still have problems if you're running multiple nb replicas and they end up on different nodes.
@LeoColomb Ah thanks! Been meaning to start organizing this now that I've come out from under the flurry of initial development on the NBE chart.
This is a changed that happened in the upstream docker image. We've had reports of it failing both on IPv6-only clusters _and_ IPv4-only clusters. (sigh 😅) The good news is...