netbox-community
Changed Templates to use the new remoteAuth.backends array, instead of .backend
First helm related commit, so be gentle. :p
In the new 5.0 release, remoteAuth.backend is deprecated and you have to specify both remoteAuth.backend and remoteAuth.backends to get a working LDAP configuration.
This PR aims to fix that by removing all references to remoteAuth.backend.
I was running into LDAP configuration / Authentication issues after the upgrade to chart 5.0.0. Traced it back to this exact same issue and while working on the same fix I noticed this Pull Request. Thanks for this 👍
Tested; This fixes upgrade from 4.1.1 to 5.0.0 with LDAP remoteAuth backend.
@Nabsku We've just done some rearranging of the repo to align it better with common practice for Helm charts. Mind rebasing this to match the new paths?
Also, it looks like maybe we need to add discussion of this change to the README.md so folks who upgrade from 4.x know the formatting is different. (Or add some shunts for backwards-compatibility so the old singular version still works. That said, the upcoming 5.x chart seems like the time to make breaking changes.)
@Nabsku We've just done some rearranging of the repo to align it better with common practice for Helm charts. Mind rebasing this to match the new paths?
Also, it looks like maybe we need to add discussion of this change to the
README.mdso folks who upgrade from 4.x know the formatting is different. (Or add some shunts for backwards-compatibility so the old singular version still works. That said, the upcoming 5.x chart seems like the time to make breaking changes.)
I've rebased my branch, thanks for the hint!
Also, regarding the discussion part, I believe that is how I found out about the missing changes in the helm chart - thus contributing this. We might need to make it more prominent but it's there. :)
I will blame this on reading through too many issues at once. I swear I did a git grep and didn't see the references, but I was clearly blind. 😅
@Nabsku FYI, I've pushed a couple of updates to your branch so the tests would get farther, but I am flummoxed by the linting error now. The indentation seems right, and there aren't any extra spaces anywhere, and your changes don't touch that line as far as I can tell.
@Nabsku FYI, I've pushed a couple of updates to your branch so the tests would get farther, but I am flummoxed by the linting error now. The indentation seems right, and there aren't any extra spaces anywhere, and your changes don't touch that line as far as I can tell.
Can you run the checks again? I believe it might've been a mistake on my side but I am pretty sure it worked before.. Running it locally works fine now :)
Do we need any changes to the
README.mdto follow up from this?
I clearly failed to read the rest of the discussion in the MR. I think we're good.