RamLavi

Results 274 comments of RamLavi

[Change](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/48c2d59a8ee255ea0d379a2ce67a1f4b27a2ab9f..eba8dd4f5a6a1923de8c850d9fb5409c6addb99f): Removed the DNM commit about ipamClaim CRD change. Conditions of "error IP allocation" will be added with empty `IPs` slice

[Change](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/eba8dd4f5a6a1923de8c850d9fb5409c6addb99f..dc13e5990f3496f8af41fadc1c793854440db113): Address @qinqon @maiqueb reviews

[Change](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/dc13e5990f3496f8af41fadc1c793854440db113..6e8a639773dc4eabfc7090f4a3fcc5c1dbc68e44): Address @qinqon [review](https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5683#discussion_r2493993302)

> So factoring thins out a little and making sure that we cover internal errors too. ``` if ipam.IsErrFull(allocationErr) { reason = "SubnetExhausted" } else if ipam.IsErrAllocated(allocationErr) { reason =...

[Change](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/6e8a639773dc4eabfc7090f4a3fcc5c1dbc68e44..4eb688f13bb1cc09d93a5173c7cfd77b558e45ce): Added suggested nits to updateStatus helper functions

[Change](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/4eb688f13bb1cc09d93a5173c7cfd77b558e45ce..facdac0ffe2d63e0a5f3ce554a0079c3fd80aebf): Addressed @kyrtapz reviews. PTAL

All updated test [pass](https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/19470198733/job/55719116797?pr=5683#step:16:17072)

[Change](https://github.com/ovn-kubernetes/ovn-kubernetes/compare/facdac0ffe2d63e0a5f3ce554a0079c3fd80aebf..59b9bceae93db6f1cde2c4620aa00499dc16af2a): Rebase + fix review no.2: removed the extraction of ipamclaim handling outside of allocate function (will attempt in separate PR)

https://github.com/ovn-kubernetes/ovn-kubernetes/compare/59b9bceae93db6f1cde2c4620aa00499dc16af2a..465ecd81dce4a3e6e9208b4db312448072546bcc: Rebase (no conflicts)

> Is this legit https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5683/files#r2575883147? mr.s rabbit's suggestion is over defensive in my opinion. We only get to this function if there was no allocation error, both of their options...