RamLavi comments

Results 274 comments of


                                            RamLavi

pkg/components: Refactor to reduce duplicate code

/remove-lifecycle rotten

pkg/components: Refactor to reduce duplicate code

[Change](https://github.com/kubevirt/cluster-network-addons-operator/compare/519dec31325c7226afa3f759218c6db35030fe55..c70c7262947e340bba1c12128f6b6714e4b741d1): Rebase

pkg/components: Refactor to reduce duplicate code

/kind cleanup

pkg/components: Refactor to reduce duplicate code

@nunnatsa PTAL

Flaky tier1: Virtual Machines Check the client When all the VMs are serviced by default (opt-out mode) and creating two VMs with same mac, one on unmanaged (opted out) namespace should detect duplicate macs gauge after restarting kubemacpool, and then mitigating that

and [here](https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1978/pull-e2e-cluster-network-addons-operator-kubemacpool-functests/1878404002324942848)

Flaky tier1: Virtual Machines Check the client When all the VMs are serviced by default (opt-out mode) and creating two VMs with same mac, one on unmanaged (opted out) namespace should detect duplicate macs gauge after restarting kubemacpool, and then mitigating that

I can't reproduce this locally. We will have to wait until the PR to fix logs is merged.

pool: Randomize mac

/hold depends on #448

pool: Randomize mac

/hold until https://github.com/k8snetworkplumbingwg/kubemacpool/pull/547 is merged

pool: Randomize mac

> /hold until https://github.com/k8snetworkplumbingwg/kubemacpool/pull/547 is merged Change: [Rebased](https://github.com/k8snetworkplumbingwg/kubemacpool/compare/bb6f1e94fe14a748e586022e5b3492b9235604b5..7c7b5de87644a34fcee964f6f695d86ed3f22647) /hold cancel

pool: Randomize mac

> I am worry that choosing a random limit it limits the amounts of MACs kubemacpool can reserve, I understand the mac range offset is never used. hmm not sure...