RamLavi

Results 274 comments of RamLavi

/hold until the proposal PR https://github.com/kubevirt/community/pull/246 gets approved. /cc @fabiand

I think we can close this PR for now, as it seems this is not the direction we are going to implement.

[Change](https://github.com/kubevirt/community/pull/246/commits/35d8d7d1eeb843c88cbfc1b83eb7ffb52207200e): Addressing reviewers' comments. @alaypatel07 @rmohr @xpivarc @fabiand PTAL

> @RamLavi will oyu be updating this spec according to Roman's comment about a a real spec? Hey, I wasn't online this past week (was sick, now better), so I'm...

Note: I am considering a pivot from the suggested solution. I will reorder and present the possible solutions so that we can discuss the best solution and continue from there.

> > Note: I am considering a pivot from the suggested solution. I will reorder and present the possible solutions so that we can discuss the best solution and continue...

Updated the proposal to exhibit all the options discussed. This is done in order to allow open discussion.

> Updated the proposal to exhibit all the options discussed. This is done in order to allow open discussion. I was expecting that by now there would be more discussion...

Added a new option suggested by @xpivarc (thanks!)

[Change](https://github.com/kubevirt/community/compare/5e1c3b24c7a2817f77391fa3ac786cb9fff62309..87662c0d9f2cc59fa64e927076af68f3d644d616): Addressed @xpivarc 's comments. @xpivarc can we change the PR title and maybe add a PR desc? The PR title should be: `virt-handler: Restrict write access to nodes` The...