Benjamin Saunders

Results 980 comments of Benjamin Saunders

An easy way to adjust playback rate would be to skip or double every 1 in, say, 20 samples. Empirically this sounds okay, especially since we're only doing it in...

It sounds slightly sped up, i.e. higher pitch, while doubling makes it lower. At 1 in 100 the difference is inaudible, but it's slightly noticeable still at 1 in 50....

I guess I'm thinking of fadeout/in as not quite the same thing as a crossfade, but I suppose the logic could be mostly shared. :+1:

> the push_next function can now become a trait function with a default implementation This is a major drawback: - Trait functions must be imported explicitly, whereas inherent functions are...

Taking advantage of the existing `TaggedStructure` sounds nice to me. I do still feel that traits can be a bit awkward, but we should balance that against the duplicate generated...

> Would appreciate a suggestion for renaming a TaggedStructure in that case I'm not sure there's a pithy term Vulkan uses here ([relevant docs](https://registry.khronos.org/vulkan/specs/latest/styleguide.html#extensions-interactions)). `TaggedStructure` still seems fine to me....

That seems like a lot of extra generated code for something that could be addressed with a three-line for loop on the caller's side.

> Terrible DX annoyance with "too many open files" errors due to buck trying to download 1000 crates at once. > Most paths in buck-out/ include the configuration hash, including...

Found some early discussion of the latter issue at https://github.com/facebook/buck2/issues/611.

Interesting idea. I'm not sure that would be terribly useful without the rest of the documentation to provide context, though.