Benjamin Saunders
Benjamin Saunders
Minimized reproducer: ``` let x: Box = Box::new(()); (&x).downcast_ref::().unwrap(); ``` The `expr_ty_adjusted` for `(&x)` is, apparently, `&dyn Any`. I guess `expr_ty_adjusted` accounts for auto-deref, whereas what's needed here is to...
The fix has been merged; I think this can be closed.
> it would be helpful for you to craft the PR commit history in a way that incorporates changes to commits into those commits, rather than by changing them with...
Which is great for the brief period where you can exactly remember what happened last review :grin:
We also want to make it easy for downstream code to allocate resources efficiently. Typically batch size is somewhat arbitrary, and very large batches can waste memory, potentially to a...
Is this fixed?
Initial bikeshedding: - Why introduce "resolves to" in addition to "yields"? - Why replace "cancel-safe" with "cancellation safe"?
Would it be simpler and sufficient to document that the clock/epoch is unspecified? Is comparing receipt times to times obtained by other means important? IIRC your application only needed to...
I'm not sure if that's necessary or correct. ACK delay describes the time that the QUIC endpoint deliberately waits, not delays forced on it by lower layers or intermediaries. Any...
Quinn does not rely on rcgen; that is only used in tests/examples. *ring* is an optional dependency. You can use cargo features to rely on aws-lc-rs instead, though I have...