Tanjona R. Rabemananjara

Results 40 comments of Tanjona R. Rabemananjara

> Also, @goord is right. We have a limited budget and I suspect that we left a 3-4 days job. Tomorrow I am back home and will submit it again....

**Unrelated:** it looks like the polarized theories have been updated (cc, @giacomomagni, @scarlehoff)? Now the C-factors are no longer present. This is the reason why the tests are failing.

The changes in [00a9839](https://github.com/NNPDF/nnpdf/pull/2145/commits/00a9839e52134ed6a02d73357731f455872d1dfb) looks good to me! I think that upon fixing the tests (which I can take care), we can merge this.

> no probs, I can do that. I will also add the proportion key to the docs. Great! Thanks 🙏🏼

There are a few datasets that have changed. Many of them are due to numerical fluctuations, so https://github.com/NNPDF/nnpdf/issues/2095 needs to be propagated. List of datasets that have been modified ```...

> @Radonirinaunimi do we want to try to merge this before going through the actual data? Sorry for the late reply, for some reasons I have not received notifications about...

This is now overly deprecated so let's close it (and in any case it will be removed in favor of the new sampling).

> sorry, wouldn't it be better to instead of having a branch here just for the pineko dev branch, to remove for now nnpdf from the pineko dev branch? >...

> ok then! I've left some small comments, although it is WIP I thought better to mention these small points sooner rather than later. > Thanks for the comments @scarlehoff!...

> Probably that's off-topic, but I just wanted to mention that with pineappl v1, we need to update the API extension notebook too. I was thinking that this branch might...