ROCm-CompilerSupport

ROCm-CompilerSupport copied to clipboard

`AMDGPUCompiler::addCompilationFlags` unconditionally adds system include directories

2

For installations in `/usr`, such as in the [Fedora](https://src.fedoraproject.org/rpms/rocm-compilersupport), [Debian](https://salsa.debian.org/rocm-team/rocm-compilersupport/-/tree/master) or [Gentoo](https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/rocm-comgr/) packages, `ROCMIncludePath` and `HIPIncludePath` are both set to `/usr/include`. Adding them to the system include directories messes up...

awehrfritz

libamd_comgr.so.2.4 segfault with amd_comgr_do_action (training a model stops at epoch 1)

9

Hello, I've just recently installed ROCm 5.2.0 on arch with the [rocm-arch](https://github.com/rocm-arch/rocm-arch) repository. Everything has worked up to this point (no initial errors, tensorflow works, `clinfo`, `rocm-smi`, and `rocminfo` produce...

7910f6ba7ee4

LLVM ERROR: Unsupported calling convention for call for llvm/clang 14.0.5

6

I'm building rocm-comilersupport against llvm/clang 14.0.5. The build was successful, but many compile test failed: ``` The following tests FAILED: 12 - comgr_compile_test (Subprocess aborted) 13 - comgr_compile_minimal_test (Subprocess aborted)...

littlewu2508

I was packaging this repo as `dev-libs/rocm-comgr` based on vanilla clang for Gentoo, and met a series of problem. Since the clang include directory in Gentoo is located at /usr/lib/clang/CLANG_VERSION/include,...

littlewu2508

From my build log: ``` ROCm-CompilerSupport/lib/comgr/src/comgr-env.h:49:7: error: ‘Optional’ in namespace ‘llvm’ does not name a template type ``` This is on Debian 11 ``` ~/amdbuild/rocm-build/build/rocm-compilersupport ~/amdbuild/rocm-build/build/rocm-compilersupport HEAD is now at...

joelandman

Ensure Clang/LLVM symbols are exposed for plugins

1

Ideally should also be forward/backported to other relevant ROCM versions. HIPRtc currently does not correctly support LLVM plugins. Specifically, symbols defined within LLVM and/or clang are not available by any...

wsmoses

@nitishjohn;@guansong;@scott-linder;@amdgerritcr We are going to enforce two factor authentication in (https://github.com/RadeonOpenCompute/) organization on 8th April , 2022 . Since we identified you as outside collaborator for this organization, you need...

DeeptimayeeSethi

Comgr calls exit, which is not advised. To quote Fedora's rpmlint tool: This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is...

Mystro256

comgr lacks MT safety

1

It seems like comgr is not working properly in multithreaded contexts. This prevents it from full-blown usage in MIOpen. ## How to reproduce Prerequisites: A linux machine with gfx900/906/908 GPU...

atamazov

use-after-free in executeAssembler()

1

https://github.com/RadeonOpenCompute/ROCm-CompilerSupport/blame/amd-stg-open/lib/comgr/src/comgr-compiler.cpp#L520 ```c++ static bool executeAssembler(AssemblerInvocation &Opts, DiagnosticsEngine &Diags, raw_ostream &LogS) { ... std::unique_ptr Str; ... std::unique_ptr Parser( createMCAsmParser(SrcMgr, Ctx, *Str.get(), *MAI)); //

Artem-B