ROCm-CompilerSupport icon indicating copy to clipboard operation
ROCm-CompilerSupport copied to clipboard

Comgr calls exit

Open Mystro256 opened this issue 3 years ago • 0 comments

Comgr calls exit, which is not advised. To quote Fedora's rpmlint tool:

This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation.

Thanks!

Mystro256 avatar Feb 14 '22 15:02 Mystro256