Raanan Weber

Results 176 comments of Raanan Weber

Reopening this, as it SHOULD be working well now

Closing again to check the out-of-memory issue on linux and node 16

Just had a thought after testing the implementation - shouldn't this be a part of the individual object tab? i.e. - open metadata for a specific object? i.e. here (all...

> > Just had a thought after testing the implementation - shouldn't this be a part of the individual object tab? i.e. - open metadata for a specific object? i.e....

I like the UI in the pop up, those buttons just need to be a part of the embedded area instead. Prettify, refresh update. When you refer to onChange you...

Merged and will follow up when deployed. Thanks for that wonderful PR!

> TypeScript does not support static `this` typings properly This is by design. Static methods belong to an object and are not inherited. They might work, depending on the way...

> This PR fixes a few typos throughout the repository. I noticed a few typos that were either part of public APIs, or that I didn't know what they should...

> > we have a dipose function somewhere? this would feel like a bug. > > https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/dev/gui/src/2D/controls/inputTextArea.ts#L1224 > > > Shadows, probably. depending on the context. > > https://github.com/BabylonJS/Babylon.js/blob/0505575d1f5a11394d499cbb2db1f42ac64fe972/packages/tools/viewer/src/configuration/interfaces/lightConfiguration.ts#L13 >...

And once again, thank you so much for all the time invested in this!