MIOpen

MIOpen copied to clipboard

User database file corrupted under Windows

6

If you guys will eventually support Windows platform, it is better to use `ios::binary` openmode here: https://github.com/ROCmSoftwarePlatform/MIOpen/blob/7a1833b9e645848b470fdb3e279aa2423f60282c/src/db.cpp#L267 https://github.com/ROCmSoftwarePlatform/MIOpen/blob/7a1833b9e645848b470fdb3e279aa2423f60282c/src/db.cpp#L276 Here we have a problem with new line characters, it's 2 bytes...

stmuxa

Compiling failure XdlopsBackwardData for fp16

6

``` ./bin/test_conv2d --half --cmode conv --pmode default --group-count 1 --disable-backward-weights --input 16, 16, 7, 7 --weights 4, 16, 1, 1 --pads_strides_dilations 0 0 1 1 1 1 --trans_output_pads 0 0...

zjing14

Use shorter name for iGEMM kernel wrapper

1

@asroy I mean this `gridwise_convolution_backward_data_implicit_gemm` is always the same (except "backward_data" of course), so I would replace it with smth like `gw_conv_fwd/bwd/wrw_igemm` or even `conv_igemm_gw_fwd/bwd/wrw`... _Originally posted by @atamazov in...

asroy

Regenerating KDB in the `develop` branch is currently not possible.

2

Regenerating KDB with new ASM kernels in the `develop` is needed to fix #2851 (the latter may be done by reverting #3002 + regen ASM kernels altogether). Regenerating KDB with...

atamazov

"-mno-xnack" flag is removed by upstream clang

7

Building and testing MIOpen with upstream clang, I got some failures. One is `test_conv2d`: The output of `AMD_COMGR_SAVE_TEMPS=1 AMD_COMGR_REDIRECT_LOGS=stdout AMD_COMGR_EMIT_VERBOSE_LOGS=1 /run/user/18014/portage/sci-libs/miopen-5.7.1-r1/work/MIOpen-rocm-5.7.1_build/bin/test_conv2d --float --cmode conv --pmode valid --group-count 1 --batch_size 8...

littlewu2508

Google tests to obey MIOPEN_TEST_HALF etc

10

(1) When the tests are run under CTest's control (i.e. in our CI): - (1.1) The tests in gtest folder must obey the MIOPEN_TEST_HALF, MIOPEN_TEST_INT8, MIOPEN_TEST_BFLOAT16 etc CMAKE variables. For...

atamazov

[MHA] Implement ExecutionPlan execute function

1

Binding Engine with arguments

kikimych

Create an issue to track workaround in #2936, which should be removed after kernel fixes _Originally posted by @msaudulhassan in https://github.com/ROCm/MIOpen/issues/2936#issuecomment-2111238800_

junliume

Incorporate fin into MIOpen

9

Add fin source into MIOpen. Allows build checks in consistent environment. Removes circular repo dependency. Updates to Jenkinsfile to add and cleanup fin tests.

cderb

[urgent] HipBuildImpl() seems fail to create temp dir or due to no GPU presents in build env

6

[build_fail.log](https://github.com/ROCm/MIOpen/files/15284300/build_fail.log) Actual Result: ``` [2024-05-10T20:01:46.194Z] /src/hip/hip_build_utils.cpp:186:42: error: expected ')' [2024-05-11T09:45:27.064Z] 186 | MIOPEN_THROW("Failed cmd: '" MIOPEN_HIP_COMPILER "', args: '" + args + '\''); [2024-05-11T09:45:27.064Z] | ^ [2024-05-11T09:45:27.064Z] /build_hip/include/miopen/config.h:98:29: note: expanded...

junliume