rocRAND icon indicating copy to clipboard operation
rocRAND copied to clipboard

Use rocm-docs-core for linting

Open saadrahim opened this issue 2 years ago • 4 comments

saadrahim avatar Jul 25 '23 20:07 saadrahim

@MathiasMagnus I tried using the scripts but there are some issues here.

saadrahim avatar Jul 25 '23 20:07 saadrahim

Codecov Report

Merging #370 (2df1c5b) into develop (6d3b085) will not change coverage. Report is 4 commits behind head on develop. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #370   +/-   ##
========================================
  Coverage    58.05%   58.05%           
========================================
  Files           51       51           
  Lines         4815     4815           
========================================
  Hits          2795     2795           
  Misses        2020     2020           
Flag Coverage Δ
gfx906 58.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 26 '23 01:07 codecov[bot]

I would prefer to wait for https://github.com/RadeonOpenCompute/rocm-docs-core/issues/489 instead, my reasoning being that GitHub is not the primary platform where development happens for rocRAND, so any issues that this linting would uncover would only come up during the upstreaming pull requests.

Maetveis avatar Nov 14 '23 08:11 Maetveis

Seems like there's a bunch of failures in CI and also in the files changed section.

stanleytsang-amd avatar Mar 13 '24 17:03 stanleytsang-amd