R2DT icon indicating copy to clipboard operation
R2DT copied to clipboard

Possible off-by-one error?

Open pzhaojohnson opened this issue 1 year ago • 1 comments

Seems like in the generate_traveler_fasta function (linked below) that there's a possible off-by-one error in generated dot-bracket structures when a sequence contains a leading 5' label.

https://github.com/RNAcentral/R2DT/blob/main/utils/rna2djsonschema.py

The first for loop would ignore the 5' label when generating the nucleotide sequence but the base-pair indices used in the second for loop to generate the dot-bracket structure are not updated to match the now shorter sequence.

pzhaojohnson avatar Oct 30 '23 20:10 pzhaojohnson