RDMurray

Results 160 comments of RDMurray

Apologies this was a long time ago. This PR moves "beacon" in settings from under the General heading to it's own section heading below the general section. please can someone...

I think the ideal way to solve this would be for Navilens to contribute directly to OpenStreetMap. It would benefit OSM because e.g. the bus stop data would be more...

I think if they agree it is a good idea, someone from Navilens should start a discussion on the OSM forum to get agreement about a Navilens tag.

@ajiteshbankulaa Thanks for working on this. To generate the strings for the announcements, you can use [LanguageFormatter.string(from: distance, rounded: false](https://github.com/soundscape-community/soundscape/blob/statemachine/apps/ios/GuideDogs/Code/Language/LanguageFormatter.swift#L74) which will automatically use the user's preference. I'm not sure...

Hi @ajiteshbankulaa did you mean to close this? It's good work and almost ready to merge.

We should definitely use `LanguageFormatter`. It is already used for distances in other callouts, it uses the user's preference for measurement units and avoids the need to duplicate translation strings....

@coderabbitai full review

Okay but this would have to wait until support for iOS 14 was removed. I think there is value in keeping iOS 15 support. The first gen iPhone se is...

Sorry I took a while to get round to looking at this. I don't see the footers appearing on device. Is it possible they only show on the storyboard canvas?...