R-Goc

Results 58 comments of R-Goc

Here is a blog from a similar failure. https://devblogs.microsoft.com/oldnewthing/20240913-00/?p=110257

No clue about arm calling convention. Not sure why that would be invalid. A few other look like function pointer as well.

what happened in this CI? I see the error but I don't understand why it happens on only these two builds, or why it happens tbh.

This is a difference in behavior in clang and gcc. Gcc is unable to tell that all control flow paths are handled. Adding a default case fixes it, but breaks...

Compare view is useless due to rebase, but everything looks fine. I'll compile locally and check.

This is the reason that I did that weird thing with the format reference: ``` D:\lib\ladybird\AK\Format.cpp(1102,39): error: call to non-static member function without an object argument 1102 | return Formatter::format(builder,...

Doing this solves the issue, but exposes it in a header. ``` diff --git a/AK/Format.cpp b/AK/Format.cpp index 61508cb5cd..6526cb0f9f 100644 --- a/AK/Format.cpp +++ b/AK/Format.cpp @@ -1092,7 +1092,7 @@ void vout(FILE* file,...

Should I push it or is there another way around it?

@stasoid does this look correct?

fixes: https://github.com/LadybirdBrowser/ladybird/pull/4682