R-Goc
R-Goc
It's creating a bit of an issue in system.h and systemWindows.cpp The issue is that when including system.h we include the sockaddr-win needed there to provide the addrinfo related things....
Ok I'll check. Maybe clang format is moving includes around.
While clang-fromat was indeed moving includes around, turns out the issue is with ws2tcpip.h. Looks like with sockaddr-win.h included the only thing needed from there is gai_strerror(). Though that can...
Should we just change AF_UNIX in SocketAddress.h to AF_LOCAL? Or define AF_UNIX to AF_LOCAL here?
It is in SocketAddress.h. sockaddr-win isn't a replacement for SocketAddress.h
This is not like for like. Winsock isn't the same as windows. So if we name it windows.h we should be including windows.h. winsock is only for the sockets. Maybe...
Didn't know that. Then it's fine. Is there anything else we might want here?
Any reason this starts with lower case specifically?
This doesn't match convention in AK, nor the normal name for it. Causes a compilation error due to non-portable-include if you write with uppercase.
I already use it. The issue is that one step.