Zachary Jones

Results 8 comments of Zachary Jones

My reply on my repo gives a manual fix but I'll plan to allow a way of running my installer in a "compatibility mode" which won't overwrite other injections https://github.com/Qwiso/QModManager/issues/1#issuecomment-367169184

@MartinSGill we both explicitly backup the original dll, is the issue.

Sorry for not being clearer. Both of our installers will inject and function, I've tested that just now What I noticed, when using `File.Copy` for backup we should ensure the...

@auser yes click to place a marker, then click on marker should change it to blue observe the console to see that the icon fillColor has been updated after clicking...

this project does not use react very well. the authors wrote this so they could market their book. ironically marketed by saying "learn react the right way" https://reactjs.org/docs/react-component.html#shouldcomponentupdate `Use shouldComponentUpdate()...

To solve this issue of re-rendering and to allow for editing of SVG data which is mentioned in other issues, I implemented a new property in `Marker.js` and changed the...

@themakerman it's just the part of the source code that i've changed. `Marker.js` from google-maps-react module. that what it looks like. not sure if it's ES5

@themakerman because, as written, it's a breaking change to the existing functionality. it's not a great way of doing things but it works for me