Donald Haase
Donald Haase
> Just left one minor comment, it occurs to me that normally you want to do one of the following: > > * Check that the KOS version is greater...
Can/will approve, but hope to hear from @Kazade . It looks like this now can satisfy any comparison that's desired against a version number. I'd want anyone else to be...
(I guess this has already been tracked mostly but didn't send earlier) My guess has been that there is something off in the implementation of `timer_getticks()` . Since that's the...
> @QuzarDC what's the "heavy performance cost being paid"? You mean the 4-values LUT or the right-shift? This code is as optimized as it can be, I think. The code...
@darcagn , would you have any interest in trying to figure out objc with this? With this you can add -m4-nofpu and it'll build for C but seemingly not for...
This is explicitly noted as a TODO: https://github.com/KallistiOS/KallistiOS/blob/master/kernel/fs/fs.c#L367 . I had called it out in https://github.com/KallistiOS/KallistiOS/issues/224 as part of the reason to document fs_pty. To my estimation fs_pty would be...
I'd generally agree, we basically already have it: https://github.com/KallistiOS/KallistiOS/blob/dbdc05cf9f64a32b679285c2bb5bb196546407d7/doc/environ.sh.sample#L112-L118 But I think there may be some happier medium for a default between the default high debug we have now and...
Would adding a callback for the periodic function of the driver be too big/unnecessary of an investment for this? I have a usecase in mind that could be made extremely...
> On second though, looking at @QuzarDC's GBA reinstatement PR, the removal of the platform-dependent `#ifdefs` around the ELF architecture/platform was a mistake. This was common code that actually could...
Switching the ordering of the peripheral shutdowns should be simple, and is certainly more correct. A big additional problem is that none of the cleanup actions that would need to...