Quinn Klassen

Results 131 comments of Quinn Klassen
trafficstars

I'll note this issue can be worked around by not using `OnWorkflow`, instead register your own "mock" workflow instead of this ``` s.env.RegisterWorkflow(ChildWorkflow) s.env.OnWorkflow(ChildWorkflow, mock.Anything).After(time.Hour).Return( func(ctx workflow.Context) (string, error) {...

gogoproto is still in the mod file because `ProtoJSONPayloadConverter` and `ProtoPayloadConverter` support gogoproto structs and we did not remove support for backwards compatibility

Closing as this is the intended behavior

@tdeebswihart That failure is unrelated to this ticket, both are data races, but the root cause it different. It should be in it's own separate ticket. edit: new ticket https://github.com/temporalio/sdk-go/issues/1240

For anyone reading this issue, the code @cretz pointed was actually dead code and not the cause of the problem. The root cause was actually a race due to how...

closing as this is fixed by https://github.com/temporalio/sdk-go/pull/426

Workflow info now includes history size and length

closing in favor of https://github.com/temporalio/sdk-java/issues/1201 since there are more attributes not passed then just SA.