James Onnen comments

Results 38 comments of


                                            James Onnen

Update climbable check

Note CollectionService is a lot nicer way to bind climbable state, so with a lack of modularity this would be a nice change.

Optimise + document Table library

Closed in favor of #321

feat: Add TintController package for colouring groups of instances

I'll take a look in a bit, but it looks like we're missing package-specific files? - package.json - README.md - default.project.json

Blend.Single changes

Side note: Rx.EMPTY never completes I believe.

fix: 'Promise.isPromise' checks metatable over reading ClassName

I'm good for this. I think we should generalize the isA() calls to be duck typing instead of this classname checks.

fix: 'Promise.isPromise' checks metatable over reading ClassName

Oh wait, this can technically break stuff because of the way Rx works with multiple copies of promises. I'm still ok with this change, but duck typing would be better....

fix: 'Promise.isPromise' checks metatable over reading ClassName

I think so! We're probably going to need to dummy-type the Promise for compatibility with Eryn's promise soon anyway.

docs: license bump & updated bad links

I'll need to do the soft shutdown stuff separately, if that's ok.

docs: license bump & updated bad links

If you give me edit permissions I can probably rebase and rewrite your branch.

Attempted to call require with invalid argument(s)

This should be patched now, will keep open for a while more.