NevermoreEngine icon indicating copy to clipboard operation
NevermoreEngine copied to clipboard

Blend.Single changes

Open OttoHatt opened this issue 2 years ago • 2 comments
trafficstars

  • Allow returning nil from the observable. We know that it will never evaluate to anything interesting, so there's no point creating a brio (which are not free). (Should also probably skip creating a brio if the passed observable is complete and evaluates to nil, i.e. == Rx.EMPTY?).
  • Propagate state of passed observable. This has just become a slightly more efficient version of a switchMap + toBrio.
  • Returning from a subscription does nothing.

OttoHatt avatar Jul 02 '23 13:07 OttoHatt

Side note: Rx.EMPTY never completes I believe.

Quenty avatar Jul 10 '23 20:07 Quenty

If propagating failure is contentious, is it possible to merge just the first of these commits for now?

OttoHatt avatar Jul 23 '23 23:07 OttoHatt