Elliott Sales de Andrade

Results 838 comments of Elliott Sales de Andrade

On the call, we were discussing whether it made sense to target all these font-related (and requiring full image rebuild) PRs to a separate feature branch, which would contain the...

Sorry for the conflict; I realize that #29199 was going to be thrown away here anyway, but I wanted to acknowledge the (new) contributor's work, and I knew you wouldn't...

I think so; it just fixes rotation, which you should be doing already.

Yes, I did see that, but wasn't too sure it was wrong or not. Please rebase on the `text-overhaul` branch for future updates (though I don't know if there'll be...

> Unrelatedly, I noticed that a large number of baseline image changes e.g. in test_axes could have been avoided if they used remove_text=True (it's ticklabels on tests that have nothing...

BTW, not sure how you're updating the images, but I tend to start with the images from [the `text-overhaul-figures` branch](https://github.com/QuLogic/matplotlib/tree/text-overhaul-figures), update the results and then only commit _what's different from...

> > BTW, not sure how you're updating the images, but I tend to start with the images from [the text-overhaul-figures branch](https://github.com/QuLogic/matplotlib/tree/text-overhaul-figures), update the results and then only commit what's...

I think you may have dropped the rebase when doing that... I've rebased and fixed the conflict. However, I've not pushed the test images, because it appears there might be...

> test modified from #29551 to also include mathtext: If I extend this test to include `\frac{abc123}{def456}`, then the fraction bar is jumpy as well, because in the `angle=0` case,...

> I figured that out. There's a bug in draw_glyphs_to_bitmap, which is fixed by OK, so then it's an additional fix here; it did seem better in several cases (e.g.,...