Elliott Sales de Andrade

Results 399 comments of Elliott Sales de Andrade

TBH, I'm not really sure about this; as you can see tests fail and I'm not sure whether this can be corrected.

As I mentioned `fedpkg update` getting stuck too, that's only for single releases I think.

It would be helpful if that link were in the README, because the only link is in the wiki, but the README says that's internal.

Since this is using the GLib functions: data: > On Windows it follows XDG Base Directory Specification if `XDG_DATA_HOME` is defined. If `XDG_DATA_HOME` is undefined, the folder to use for...

You are deleting it in _all_ cases; you only want to do that if you created a temp file, not if the user entered a GEDCOM file to load. Also,...

> It actually has both. Ah, that is good to see. There are a lot of extra labels added that seem to be empty and unused, which made it difficult...

For example, [here](https://github.com/gramps-project/gramps/pull/1297/files#diff-b127a9021ebe3792cdd3438a5ad81174fe2663676cd20d8ab3fa5c8d4469adcdR1256-R1257) is an empty label that is added to the window and then the variable is thrown away.

If you want to do that, you should set a margin on the widgets, or the spacing on the vbox overall.

Hmm, no need to go through too much trouble; I'd be happy if I could compile with the fallback only (maybe I just need to disable them and leave it...

TBH, I'm not sure how to set that up. Does it define one of the `linux` constants also? I guess checking for `__ANDROID__` might help if needed then.