Qingqi Shi

Results 6 comments of Qingqi Shi

> Could you provide a reproduction? [This StackBlitz sandbox template](https://stackblitz.com/edit/stackblitz-starters-maxhor?file=src%2FApp.tsx) may be a good starting point. Simple repro with the `Autocomplete` component, but essentially anything that uses the `useControlled` hook...

Seeing the same issue when attemping to set a token inside a dynamic style ``` const styles = stylex.create({ dragging: (position) => ({ [tokens.position]: `${position}px`, }), }); ``` I see...

> `useControlled` doesn't warn, but the component logged 2 other warnings > > Though this doesn't necessarily block the PR, just wanted to ask @iammminzzy if you tried these changes...

Oh yeah that would be a much better solution. I imagine preferablly you'd respect something like a browserlist to determine if a vendor prefix is required. Will close my PR.

Just pulled the latest main branch to double-check this. I added @oliverpascal's exact example to the tests, and it indeed passes. Here's a screenshot showing the test passing. ![image](https://github.com/facebook/stylex/assets/6232457/258c617d-db51-48eb-a476-b889d710a276)