奇安信CodeSafe

A 'sizeof' for a pointer issue

2

Hi all, There is a sizeof issue found by Qihoo360 CodeSafe Team. Details as bellow: https://github.com/litecoincash-project/litecoincash/blob/3bcc790cacad47421848d821b9ba18d8c86a5f7b/src/test/serialize_tests.cpp#L363 the argument of macro 'FLATDATA' is charstrval which is a pointer defined here: https://github.com/litecoincash-project/litecoincash/blob/3bcc790cacad47421848d821b9ba18d8c86a5f7b/src/test/serialize_tests.cpp#L347...

A possible null point dereference?

3

Hi all, There is a possible null pointer dereference issue found by Qihoo360 CodeSafe Team. Details as bellow: Function State() could return null pointer: https://github.com/litecoincash-project/litecoincash/blob/3bcc790cacad47421848d821b9ba18d8c86a5f7b/src/net_processing.cpp#L271-L276 After calling this function in...

no limitation for "%s" while calling fscanf()

2

https://github.com/facebook/fboss/blob/8865126044e7a6647c2ba7b0aa0c2d974edeb1eb/fboss/util/nic_util.cpp#L494

Unused value

5

https://github.com/facebook/fresco/blob/c00077a4311fa220548a7ec66038c146f04d3ceb/imagepipeline-base/src/main/java/com/facebook/imageutils/TiffUtil.java#L172 Unused value

https://github.com/facebook/nailgun/blob/84d7725f59210f4fd03f1d18191558367829c986/nailgun-examples/src/main/java/com/facebook/nailgun/examples/Hash.java#L57 Unused value

https://github.com/facebook/mysql-5.6/blob/f02f1784cf92efada3d139f58ecb449781f7d91a/sql/native_procedure.cc#L204

https://github.com/facebook/openbmc/blob/e91ee6437c9dead5b3184b61faf9c2f04434e85c/meta-facebook/meta-elbert/recipes-utils/wedge-eeprom/files/utils/elbert_weutil.c#L34

https://github.com/facebook/openbmc/blob/a5afaf50c1ab9695dd666ee63943b1218cabab18/common/recipes-core/rackmon/rackmon/modbus.c#L53

Stream is opened https://github.com/facebook/openbmc/blob/2e61cd4c6a9c23789a2a952673ee7f6671b92f00/common/recipes-core/fw-util/files/tpm.cpp#L34 Opened file never closed https://github.com/facebook/openbmc/blob/2e61cd4c6a9c23789a2a952673ee7f6671b92f00/common/recipes-core/fw-util/files/tpm.cpp#L44

Stream is opened https://github.com/facebook/openbmc/blob/9d57980189e52b79f365cb58214f1b23dbd63813/common/recipes-core/fw-util/files/tpm.cpp#L34 Opened file never closed https://github.com/facebook/openbmc/blob/9d57980189e52b79f365cb58214f1b23dbd63813/common/recipes-core/fw-util/files/tpm.cpp#L44