fboss icon indicating copy to clipboard operation
fboss copied to clipboard

no limitation for "%s" while calling fscanf()

Open QiAnXinCodeSafe opened this issue 5 years ago • 2 comments

https://github.com/facebook/fboss/blob/8865126044e7a6647c2ba7b0aa0c2d974edeb1eb/fboss/util/nic_util.cpp#L494

QiAnXinCodeSafe avatar Aug 26 '20 06:08 QiAnXinCodeSafe

@bdd

iris577 avatar Mar 01 '21 17:03 iris577

Not only that, but sprintf on the line before would be more secure as snprintf, and strcat on the line after would be more secure as strncat.

slogan621 avatar Apr 01 '21 06:04 slogan621