purell

purell copied to clipboard

FlagRemoveUnnecessaryHostDots doesn't remove extra dots between parts

2

It seems like FlagRemoveUnnecessaryHostDots only removes extra leading and trailing dots in the hostname part of the URL. For instance a URL like "http://host..com" doesn't get the extra dots removed.

michael-peterson-cisco

Can we remove idna hacks from NormalizeURLString?

2

Any idea if the fix was merged to idna package? https://github.com/PuerkitoBio/purell/blob/master/purell.go#L166 Is this still relevant?

let4be

NormalizeURL does not perform IDNA normalization

1

IDNA normalization is only performed in `NormalizeURLString`, but that function returns a `string`. If you need a `url.URL`, you must then parse the result of `NormalizeURLString`, which means you are...

eliaslevy

Return to using stdlib's URL escaping

5

[Issue 5684](https://github.com/golang/go/issues/5684) is now closed, so it might be time to revert [PR 9](https://github.com/PuerkitoBio/purell/pull/9).

ghost

This PR gets most tests to pass using `net/url.String()` for url escaping. The only failing tests are for `EncodeNecessaryEscapes` and `DecodeUnnecessaryEscapes`, which rely on implementation details of `net/url` and `urlesc`....

natasha-jarus