purell icon indicating copy to clipboard operation
purell copied to clipboard

NormalizeURL does not perform IDNA normalization

Open eliaslevy opened this issue 6 years ago • 1 comments

IDNA normalization is only performed in NormalizeURLString, but that function returns a string. If you need a url.URL, you must then parse the result of NormalizeURLString, which means you are parsing the URL yet again, which is wasteful.

As NormalizeURLString calls NormalizeURL, the IDNA normalization in the former should be moved to the later, resulting in the URL passed to NormalizeURL having its host field IDNA normalized.

eliaslevy avatar Jan 04 '19 01:01 eliaslevy

Hello Elias,

I think you're right, makes sense to me. I don't plan on working on purell in the near future, but happy to assist getting a PR merged that would address this.

Thanks, Martin

mna avatar Jan 04 '19 03:01 mna