Chris Blume

Sounds good. It is likely still showing up here because there have been no code changes and GitHub remembers the last CI results. But future changes should be fine.

Agreed. Thank you for doing this, @nmoinvaz. Warnings are allowed by default. Errors will not give a green check mark. We can add a flag to treat warnings as errors...

Oops. Let me correct myself: There are 3 workflows. The "Configure" workflow behaves the way I described above. There is also a "CMake" workflow that builds and tests correctly on...

ISB = In-Source Build. For CMake, it is common to: $ mkdir build $ cd build $ cmake .. Then all build files are inside the build/ subdirectory, rather than...

Could you elaborate on bypassing ctest? Everything should continue to work the way it did, including ctest.

I like your idea of keeping as much as possible the same between local & CI testing. The existing local tests just print to stdout, which isn't an option for...

Maybe not a bad idea for the --junit command line parameter to add to the existing output. The problem was I wanted to preserve the old behavior (which called exit(1))....

I'm not sure about the K&R requirement for testing. That's probably up for discussion among the zlib contributors / maintainer. I suspect it would be ideal but there might not...

@nmoinvaz Right. Will do. :) I mentioned earlier in the thread that GitHub Actions weren't an option when we first looked because of security. But something about that has changed...

Good idea to get the environment variables. I'll try that. I'm not sure I like the idea of moving things to globals though. I could imagine a situation where we...