Profpatsch comments

Results 462 comments of


                                            Profpatsch

Fix: prevent allow notifications prompt on rotation

Okay here’s an answer by ChatGPT which I think corresponds exactly to what I figured out but in a pretty well-phrased manner: To check whether a user has **explicitly denied...

Fix: prevent allow notifications prompt on rotation

@Stypox I think I fixed it and implemented it correctly with the `PermissionRequest` callback thingy, PTAL

Support package trees containing absolute symlinks

I was hit by this as well, my use-case is that I have a bunch of `/nix/store/` paths that I want to link to from my user directory.

Fix clearing queue when tapping on timestamp

Edit: added videos

Fix clearing queue when tapping on timestamp

Maybe because this is based on `master` not `dev`?

Fix clearing queue when tapping on timestamp

@SavSanta Okay now the artifact is there, happy testing :)

Fix clearing queue when tapping on timestamp

@SavSanta you can also test https://github.com/TeamNewPipe/NewPipe/pull/12254, which is all these changes plus the timestamps skips the current player instead of always opening the popup

plugin: expose NewTabFromBuffer to Lua

Yes, if I grep through the source every place that uses this in the source code does a non-atomic add to the tab list right after, so I propose refactoring...

plugin: expose NewTabFromBuffer to Lua

I’d be okay with creating a specific plugin API that is designed to be used from lua and separate from the internal package docs, even if it means breaking backwards-compatibility....

Use Android's elapsed time formatting

I tried it on current `dev` looks good, LGTM!