NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Use Android's elapsed time formatting

Open Isira-Seneviratne opened this issue 1 year ago • 1 comments

What is it?

  • [ ] Bugfix (user facing)
  • [x] Feature (user facing)
  • [x] Codebase improvement (dev facing)
  • [ ] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use Android's elapsed time formatting functionality to format durations. This allows the durations to be formatted in the same way as in the official YouTube app, and handles formatting depending on the locale.

Before/After Screenshots/Screen Record

  • Before: Screenshot_20240707-104856

  • After: Screenshot_20240707-104941

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Isira-Seneviratne avatar Jul 07 '24 05:07 Isira-Seneviratne

I tried it on current dev looks good, LGTM!

Profpatsch avatar Nov 18 '24 14:11 Profpatsch