Alexander Prinzhorn
Alexander Prinzhorn
This was introduced by https://github.com/Prinzhorn/skrollr-menu/commit/ebb39bba#diff-14e11108e3fcf79bc01a46d211744495R141 I'm not sure though why I thought it would be a good idea to fall back to `0` when the popstate event doesn't deliver any...
Reading through #3 again maybe http://stackoverflow.com/questions/10742422/prevent-browser-scroll-on-html5-history-popstate was the reason for that. Because if I remove that code, then Chrome will scroll to the anchor by itself, which is not desired...
I'd need to take a closer look at this, but I'm busy. Maybe someone can play around with it and see what happens if the popstate is ignored, if it...
Am I right that, if #9 gets included, you can just do these calculations outside of skrollr-menu?
Same here. I want to migrate a http://harpjs.com/ project to parcel. Harp has a [`harp.json`](http://harpjs.com/docs/development/globals) for data that is available to all templates and [`_data.json`](http://harpjs.com/docs/development/metadata) which maps filenames to data....
Welcome! Sure, go ahead. Feel free to post any questions here. You can take a look at the changes made in https://github.com/mitmproxy/mitmproxy/pull/5133/files (which was never merged) 1. Define exit codes...
Also https://github.com/mitmproxy/mitmproxy/blob/main/CONTRIBUTING.md contains all instructions needed to setup the local Python environment
If you want to you can still create a pull request and maybe we can figure everything out. In my original PR I had one test https://github.com/Prinzhorn/mitmproxy/blob/6d5db0dc6a97f0667b5a163b0f8e9ac5a3806b4b/test/mitmproxy/utils/test_exit_codes.py It's mocking `print`...
@kiklidash sure! I think everything that needs to be done is outlined above.
> Can you help me out with this? I failed writing the tests as well :sweat_smile: . You can open a pull request with what you have and we can...