Price Hiller

Results 51 comments of Price Hiller

Just ran into this as well, would be awesome to see this fixed, maybe utilizing a virtual environment going forward or just exporting the variables as needed for that invocation?...

I'd be willing to take a crack at this. I just want to know if serialization is something that is open for discussion, or if manual parsing of the values...

I'll take a look at this by this weekend and see about resolving it if nobody else does as a heads up.

The place to embed that information is over here: https://github.com/NeogitOrg/neogit/blob/3d63d76f04dc7102c83a057ded30a93822b59dec/lua/neogit/lib/git/log.lua#L273 Or do some custom parsing for the commit in `render_section`, over here: https://github.com/NeogitOrg/neogit/blob/3d63d76f04dc7102c83a057ded30a93822b59dec/lua/neogit/status.lua#L193 Not sure what the best approach on...

I have it working on [this branch](https://github.com/treatybreaker/neogit/tree/feat/author-column-recent-commits). ~No flags to opt in or out,~ but this is how it looks: ![image](https://github.com/NeogitOrg/neogit/assets/58627896/416102dc-1458-4985-8e35-6f6fcf5b53d5) Neogit has to be setup with the option `recent_commit_include_author_info...

Yep, definitely going to PR. Writing some tests for it currently 😎.

> @PriceHiller can you review and test this to see if it works ok? Will check here in a bit when I get home

I'll pick this up after I finish out #627 and #629 if nobody else does as a heads up. Probably shove it in the [foldexpr](https://github.com/nvim-orgmode/orgmode/blob/cbb10d4c7514680e90f791d62f1168cb87aad0ce/lua/orgmode/org/indent.lua#L79).

I can certainly refactor this to be "ensure output directory", that's more correct, you're absolutely right. If you're ok with this feature, I can introduce a new commit that changes...

Great! I'll try to get something to you around Tuesday.