Twice
Twice
First of all, thanks for your suggestions! > Is it possible to improve as such? In protopuf, `uint32_field` is an alias for `varint_field`, and `varint_field` is an alias for `field`....
Sure, but probably the biggest advantage of translating from protocol buffers language to protopuf c++ type definitions is that many existing `.proto` files can be reused, which would be lost...
Do we need to enable TLS in docker images? Currently TLS is enabled in nightly dockerhub images.
> @PragmaTwice the issue here is what distros are supported on GitHub Actions (public). I think we can use images in docker hub, e.g. ```yaml jobs: build: runs-on: ubuntu:latest container:...
> > That is to say, the type used in the original code shoule be the same here. In this pr, regardless of whether the type can be adjusted logically....
Hi @tanruixiang, I notice there is also some code using `std::stoul` or `std::stoull` in kvrocks, do you want to also replace them in this PR? Or it is OK to...
> > Hi @tanruixiang, I notice there is also some code using `std::stoul` or `std::stoull` in kvrocks, do you want to also replace them in this PR? Or it is...
Thanks. I will merge it soon.
It sounds good to me. cc @tisonkun
> +1 I have a similar idea. Glad to see someone pick it up. Wire to the `x.py` script may spend some time to improve the usability. I notice that...