Ben Peachey
Ben Peachey
> 1. The user can define the legend text via a new $label=... parameter Sounds good. > 2. add to SHOW_LEGEND() and SHOW_FLOATING_LEGEND() a $showStyle(?) parameter Also good. > 3....
Regarding > do you have a better name for `showStyle`? and > `$legendTypeDisplay` is better but not there yet. Currently, I am oscilating between "shapeDescription" and "legendVerbosity" or something like...
I think "legendLayout" is a good description. Lets go with that. Skipping pictograms sounds like a good plan. Only having "none", "normal" and "small" is good enough. As to "no-color",...
@kirchsth Do you want this to be part of v2.5 or should we bump it to v2.6?
> I propose it be recognized by bumping the solid protocol version from 0.9.x to 2.0.0. Can we please **not** do this and just go with `0.10`? Especially as "version...
@stockiNail Great stuff! Looks like that solves my usecase. :+1: Great to have the codepen example as well, gives me something to play around with.
@stathissideris This is your friendly 3 month reminder that the community at large is still hoping you'll see fit to add @pepijnve as a maintainer to get things moving again...
I'm in favor of moving away from `master`. I'd say, for now, lets just move to `main` ASAP (since we're making other soft-breaking changes to our dev environment anyway). We...
Places that need editing for this rename: https://github.com/PHPCSStandards/composer-installer/blob/5227b24999e01c09a0f23b9bf53c8ee13eec4d05/.github/ISSUE_TEMPLATE/bug_report.md?plain=1#L52 https://github.com/PHPCSStandards/composer-installer/blob/8ab9bb58b13045f5e64ebe9ba13d8701c416dcf3/.github/workflows/integrationtest.yml#L8 https://github.com/PHPCSStandards/composer-installer/blob/8ab9bb58b13045f5e64ebe9ba13d8701c416dcf3/.github/workflows/quicktest.yml#L8 https://github.com/PHPCSStandards/composer-installer/blob/8ab9bb58b13045f5e64ebe9ba13d8701c416dcf3/CONTRIBUTING.md?plain=1#L10 https://github.com/PHPCSStandards/composer-installer/blob/8ab9bb58b13045f5e64ebe9ba13d8701c416dcf3/CONTRIBUTING.md?plain=1#L134
@jrfnl Do we want to make this change as well for the v1 release?