Xuewen Shi

icon indicating a website link http://polarlion.github.io/ icon indicating an email [email protected]

icon company Dongbei University of Finance and Economic icon location Dalian, Liaoning Province, China

Results 4 issues of Xuewen Shi

Chinese Sentences in train.en

1 comment

Hi, I found some Chinese sentences (about 4000 sentences) in train.en file. for example ![image](https://user-images.githubusercontent.com/6574696/39090473-1aa8f13a-4613-11e8-878c-53b2484d1feb.png) I'm not sure if these bugs will affect other parallel data. Thanks

opts "-gumble_weight" type int (should be float?)

https://github.com/jiasenlu/visDial.pytorch/blob/f1aa59704902bdbf4be8e507b30f55d87633debb/train/train_all.py#L77

ques_hidden1 or ques_hidden2?

https://github.com/jiasenlu/visDial.pytorch/blob/f1aa59704902bdbf4be8e507b30f55d87633debb/train/train_all.py#L252 ques_hidden1 = netE_d.init_hidden(opt.batchSize) why ques_hidden1 is one of the inputs of netE_g instead of ques_hidden2 which is generated from netE_g? Thank you very much.

This code does nothing ?

1 comment

https://github.com/jiasenlu/visDial.pytorch/blob/f1aa59704902bdbf4be8e507b30f55d87633debb/misc/dataLoader.py#L117 Hi, I found this code does nothing for ans_idx[i] is a float number while opt_ids is an int matrix. Did you mean "opt_ids = np.delete(opt_ids,self.ans_ids[index, i], 0)" instead of...