Pokechu22
Pokechu22
Fifoci diff prior to #10477: https://fifo.ci/version/494dac23d8b2f3db816787b678d910af588f1bb6/
I'm a bit confused why the same initialization isn't done with `ocol1` (see also b573319f8f2f0f4deab98b9261b585610ecb6143 / #6031) and why it's being restricted to D3D - I guess other platforms might...
`uint_output` will always be false on non-D3D backends, though: https://github.com/dolphin-emu/dolphin/blob/fa30ba18f5c9dbf06f7df0c1e9bd04065a2c439f/Source/Core/VideoCommon/PixelShaderGen.cpp#L311-L320 IMO it'd be clearer to remove the extra D3D since if `ocol0` is a `uint`, it'd always be best to...
It looks like UberShaderPixel still has a case of `(api_type == APIType::D3D && uid_data->uint_output)`. I don't think it'll generate a warning but it still might be a good idea to...
Could you split the >4GB file change into a separate commit from the file scanning change? I'm not familiar with the resource pack code (or minizip as a library) so...
The way the audio backends currently seem to work is that the header is always included, but if the backend isn't supported it would just produce this: ```cpp class OpenSLESStream...
> Does anyone have any games that use points/lines with texture offsets? I haven't tested that because I don't know what games to test. The best game to test with...
I fixed the same issue in #10741 (446e4fbbb0156383ffffadaadf5300d54378c777), though I specifically fixed the broken bounds check in WaveFile so that no audio would be recorded in those broken cases (and...
I guess more importantly, did you have audio dumping (Movie → Dump Audio) enabled when the crashes occurred? (Are there a bunch of files in `Dolphin Emulator/Dump/Audio`?) If you didn't...
I've created #11011 to add some assertions to hopefully make it more obvious when this overflow occurs. I don't think a resizable buffer is the right choice, but I'm also...