Pokechu22
Pokechu22
Thanks, I've applied that change (and regenerated the parser/grammar to fix the merge conflict). > (Note that I didn't have to manually retype the variables, but there's still one tiny...
IMO introducing a new PcodeOp is cleaner than handling the userop names, since the userop names are inconsistent (ARM uses `count_leading_zeroes` while everything else uses `countLeadingZeros`). But, introducing a new...
On further thought, a separate PcodeOp for `countLeadingOnes` is not needed, as `countLeadingOnes(x)` should be equivalent to `countLeadingZeros(~x)`.
> and that theres a way better reason for them to exist than CPUI_EXTRACT and CPUI_INSERT, which really ought to just be shifts, masks, ors instead of introducing a totally...
I've installed bison 3.0.4 from source (and am still using flex 2.6.4), which eliminates most of the noise from running `gradle lexSleigh yaccDecompiler`. Even after running it, I did need...
`countLeadingOnes` has been removed; this is ready for review again.
JMC's testing indicates that this works correctly on android, too (quake GX is [fixed](https://cdn.discordapp.com/attachments/855818254341767218/993727067831144478/Screenshot_20220704-235346.png), while rs2.dff and RogueSquadron3Bumpmapping.dff [both](https://libera.ems.host/_matrix/media/r0/download/matrix.org/IdDEFMbSKIevZohvJShjSeWI/Screenshot_20220705-000326.png) render [correctly](https://libera.ems.host/_matrix/media/r0/download/matrix.org/IkGUoZhWgVcUCxLPCRIxYGoR/Screenshot_20220704-235826.png)).
I've confirmed that the difference for Metroid Prime is accurate, and that this PR also fixes all of the mesa issues (without reintroducing problems such as [this](https://fifo.ci/compare/7419214-7410578/)). HWDolphin (EFB to...
> Somewhat relevant question, why are the fifo builds so strange these days? Seems like any graphical changes it tends to report odd differences (my post-processing PR showed strange results...
After looking into it further, I've found a few things. The source of these NaNs and other weird values in the `dir` field comes from uninitialized variables, as I previously...