Dhaivat Pandya

Results 29 comments of Dhaivat Pandya

Throwing error seems like the right approach here. I think the generally accepted idea is that you shouldn't have two queries with the same name and it seems reasonable to...

This makes sense. Should be a pretty easy fix if anyone wants to contribute. Likely have to add some preprocessing code [here](https://github.com/apollographql/persistgraphql/blob/master/src/ExtractGQL.ts).

@myyellowshoe @lemccarthy Sorry guys - this summer has been pretty busy but I'm back now. To clarify, the issue is that if there is a single file that *doesn't* contain...

Yeah, definitely! In fact, that would help solve #17 as well since people could just build stuff on top of the `ExtractGQL` class or similar. Would be happy to accept...

@lewisf Great! Most of those issues and general direction look good to me. However, I did think that the package you would be building wouldn't actually include any of the...

Hey @lewisf any progress on this? Any way I can help?

Yes, totally agree with this. I think the generics solution should work perfectly. Would you like to submit a PR that implements this?

Sure, that sounds great. Please let me know if I can help in some way.

Hi @jasonmorita - sorry for the delay. I'll look at this shortly.

@jasonmorita I think the relevant issue here is #34. There will likely be an effort to change the structure that `persistgraphql` uses to align with the one with `apollo-codegen`. I...