leiliang issues

Results 3 issues of


                                            leiliang

- [LKImageLocalFileLoader dataWithRequest:callback:] fileURL 生成应该使用 - [NSURL fileURLWithPath:] 而不是 - [NSURL URLWithString:]，如果 request.URL 中可能包含 fileURL:// 前缀，则此处存在歧义，是否应该替换其他属性或者进行重命名？

- (void)dataWithRequest:(LKImageRequest *)request callback:(LKImageDataCallback)callback { if (![request isKindOfClass:[LKImageURLRequest class]]) { NSError *error = [LKImageError errorWithCode:LKImageErrorCodeInvalidLoader]; callback(request, nil, 0, error); return; } NSString *URL = ((LKImageURLRequest *) request).URL; NSURL *fileURL =...

LKDispatch 函数内是否应该将 dispatch_sync(queue, block) 改为 dispatch_async(queue, block) ？

inline static void LKDispatch(BOOL sync, dispatch_queue_t _Nonnull queue, dispatch_block_t _Nonnull block) { if (sync) { block(); } else { if (dispatch_queue_get_label(queue) == dispatch_queue_get_label(DISPATCH_CURRENT_QUEUE_LABEL)) { block(); } else { dispatch_sync(queue, block);...

- [LKImageRequest generateIdentify] 判断 processorList 元素个数为 0 后是否应该进行 return？

源码为 ``` - (void)generateIdentify { if (self.processorList.count == 0) { self.identifier = self.keyForLoader; // return; ??? } self.identifier = [NSString stringWithFormat:@"%@:%@", self.keyForLoader, [LKImageProcessorManager keyForProcessorList:self.processorList]]; } ```