Piotr Sikora

Results 215 comments of Piotr Sikora

> @PiotrSikora Is there anything blocking this? Reference documentation for `proxy-wasm` would be super useful for new implementations. Nothing major, I need to address some comments and do a minor...

1. At the very least, you need to split this into 2 PRs and separate update of dependencies from enabling default features, otherwise this is unreviewable. 2. What's the justification...

> I can just enable one feature, 'vtune' instead of all default features. `vtune` is not `c-api` feature, so it wouldn't be enabled with this change anyway, would it? >...

> On the default features - I had hoped that features like `pooling-allocator` and `parallel-compilation` would be helpful for perf in some cases. Would it make sense to enable these...

> Perhaps we should separate this into 2 PRs? one for wamr 1.3.0 another to do skip leading padding for aot? It seems that skipping is done only for AOT,...

@mpwarres @kyessenov could one of you look at it? Thanks!

> This PR adds a variant of NullVm, DynVM, that can load in native modules as dynamically linked modules. Nitpicking, but if we're still talking about the NullVM, then I'd...

@mpwarres could you take a look at this (and fix macOS CI while at it)?

macOS build issue was fixed 8 months ago in [v8@de4e49260f908ca31ee64794c89b04cb004554be](https://chromium.googlesource.com/v8/v8/+/de4e49260f908ca31ee64794c89b04cb004554be), so you need to either update V8 first (maybe split this PR into 3 PRs updating each runner separately?) or...