proxy-wasm-cpp-host icon indicating copy to clipboard operation
proxy-wasm-cpp-host copied to clipboard

Update ubuntu runner image to ubuntu-22.04

Open mpwarres opened this issue 1 year ago • 4 comments

Update ubuntu github runner to the same image used by Envoy:

ubuntu-20.04 -> ubuntu-22.04

Updates to windows and macos runner images will be in separate PRs, since they introduce build failures.

List of available images here.

Partially addresses #372

mpwarres avatar Sep 26 '23 11:09 mpwarres

Looks like there's a MacOS build issue and Windows msvc_not_found with the updated runners, working on addressing those.

mpwarres avatar Sep 26 '23 13:09 mpwarres

macOS build issue was fixed 8 months ago in v8@de4e49260f908ca31ee64794c89b04cb004554be, so you need to either update V8 first (maybe split this PR into 3 PRs updating each runner separately?) or cherry-pick that fix.

Personally, I'd do the former and update Ubuntu, update V8, update macOS, and then figure out issues with Windows.

PiotrSikora avatar Sep 26 '23 18:09 PiotrSikora

FWIW - While working on windows CI failures for my other PR, I noticed similar issue when I tried with msvc 2022. It seems to be due to msvc 2022 having vcpkg directory inside of VC directory, which throws this check off. More discussion is here https://github.com/bazelbuild/bazel/issues/18592#issuecomment-1591067742 This is resolved in latest bazel as seen here in this patch . The workaround, if not updating to latest bazel, would be to remove/move vcpkg directory (I needed bazel clean --expunge otherwise it failed). Worked locally for me.

rahulchaphalkar avatar Sep 29 '23 03:09 rahulchaphalkar

Great--thanks for the tip @rahulchaphalkar! I've been sidetracked by a few other work items this week but will get back to this this weekend.

mpwarres avatar Sep 29 '23 15:09 mpwarres