Pinta comments

Results 9 comments of


                                            Pinta

Quiet Contemplation doesn't count as drinking

Workaround by using this snippet. https://gist.github.com/Pinta365/36abc2619c7e2c73a1ac8c35a8cf4427

Cinder Nectar not showing up drinking status.

Added a PR #306

Cinder Nectar not showing up drinking status.

Workaround: Use a snippet to extend isDrinking https://gist.github.com/Pinta365/36abc2619c7e2c73a1ac8c35a8cf4427

Cinder Nectar not showing up drinking status.

> @andybergon The change is not live as far as I know so we should probably leave it open to prevent someone else from opening a duplicate. Unless the maintainers...

fix(publish): honor jsr.json fallback and flag config conflicts

@coderabbitai help

fix(publish): honor jsr.json fallback and flag config conflicts

> **Actionable comments posted: 0** > > 🧹 Nitpick comments (1) > > cli/tools/publish/mod.rs (1)> `1573-1625`: **Tests cover core scenarios.** > > > The tests verify: > > > >...

fix(publish): honor jsr.json fallback and flag config conflicts

Thanks for the review @dsherret, would you mind going through these changes? - `jsr.json` fallback in `WorkspaceDirectory::maybe_package_config()` (single source of truth) - Conflict detection in `Workspace::diagnostics()` - CLI consumes workspace...

fix(publish): honor jsr.json fallback and flag config conflicts

> We don't want to support jsr.json outside of deno publish. It's too many config files to probe for (slow) Right. Ok, I understand. I'll revert the deno run resolve...

fix(publish): honor jsr.json fallback and flag config conflicts

Alright. Please check this out when you get a chance @dsherret. I reverted the change to the runtime package resolution.