Ping Xie

Also I think there is another (0-day) bug. We never check the sender's config epoch before accepting its claim of being a primary. https://github.com/valkey-io/valkey/blob/unstable/src/cluster_legacy.c#L3119 _Originally posted by @PingXie in https://github.com/valkey-io/valkey/issues/754#issuecomment-2222039485_

[Daily Test Failure] tests/unit/memefficiency.tcl in test-ubuntu-32bit

1

``` *** [err]: Active defrag big list: standalone in tests/unit/memefficiency.tcl Expected 1.99 < 1.1 (context: type eval line 89 cmd {assert {$frag < 1.1}} proc ::test) ``` https://github.com/valkey-io/valkey/actions/runs/9752760801/job/26916855099#logs

I have a theory about how this could happen. 1. We had a stale `PONG` message issue, which was fixed in commit https://github.com/valkey-io/valkey/commit/28976a9003c6dd5cdd7225c5bc90743b4fcde13c https://github.com/valkey-io/valkey/blob/2b76c8fbe2ccadaee2149e4b9b7c7df7ff0d07b6/src/cluster_legacy.c#L3271 2. However we didn't bail after...

[DOC] Document the clang-format flow

4

[Will add to CONTRIBUTING.md] **How to install clang-format 18 on a Debian box** ``` sudo apt-get update -y sudo apt-get upgrade -y sudo apt-get install software-properties-common -y wget -O -...