Ping Xie
Ping Xie
## Overview This PR significantly enhances the reliability and automation of the Valkey cluster re-sharding process, specifically during slot migrations in the face of primary failures. These updates address critical...
I have validated that these settings closely match the existing coding style with one major exception on `BreakBeforeBraces`, which will be `Attach` going forward. The mixed `BreakBeforeBraces` styles in the...
Here are the problems that I think we need to solve in the current cluster: 1. strong consistency (for cluster topology) cluster topology is concerned with which nodes own which...
This feels almost like a separate major decision since it's so deeply rooted in this code base. We have atomics and other C99 and later features, but not bool and...
I know we discussed it, but I forgot the discussion. I still think it's odd that we are putting the replica online before it has the slot information, since it...
> I agree. I'm saying we already have the notion that a client is blocked with a pending command, that can get re-executed once the blocking is done. (That is...
Follow up of #323
We could also add a make target like `make format` that just formats the code appropriately, which can be run if CI fails or before committing. _Originally posted by @bjosv...
This pull request introduces several changes to improve the type safety, and clarity of Valkey's dictionary implementation: - Getter/Setter Macros: Implemented macros like `DICT_SET_KEY`, `DICT_SET_VALUE`, and `DICT_GET_VALUE` to centralize type...
``` *** [err]: Empty-shard migration target is auto-updated after failover in target shard in tests/unit/cluster/slot-migration.tcl R 6 didn't assume the replication master in time *** [err]: Empty-shard migration source is...